Conversation
…oad dialog changes as a consequence, refs #85
history instead of simply the last upload
ntamas
approved these changes
Mar 30, 2026
volfpeter
added a commit
that referenced
this pull request
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
I've refactored the upload history. Instead of keeping the per-UAV outcome of a single execution for each job type, we now keep all in a history whose is capped at 8 items (data is never lost, the history is compacted when it exceeds the maximum size).
Since we have the full history, we now show the last upload status for all UAVs in the upload dialog. UAV statuses that come from earlier uploads are styled slightly differently. (The in-progress upload or the latest completed one if no upload is in progress is considered as the latest status.)
The counters in the upload dialog now show the overall summary, including earlier uploads.
The "successful" and "failed" counters can still be clicked, but now they simply add all UAVs with the given status to the queue, they don't automatically trigger the upload. These are 2 breaking changes in the UX that bring consistency (with the counters, the status pills, and the "waiting" click handler).
The status of the "Upload show data" button in the control panel is now calculated from the show upload job's history (not including running uploads). It is green only if last upload status of all UAVs in the show mapping is success.
Also, the "Upload show data" button in the control panel only shows the currently executed upload job's progress if the job is a show upload (and not parameter upload for example).
TODOs