Skywire Mobile: Fix Series 1 bugs and implement requested features (Telegram feedback) - #3833
Merged
mrpalide merged 35 commits intoAug 12, 2026
Conversation
…ewport — overlay scrolls, margin:auto centres, focused field revealed
…eam call, since Job.cancel can't reach a blocking upload
…nd stop capturing from lying about it
…connect — control envelopes go live-only, and a retried invite is not news
…le lookup overwriting a picture the user chose
…s, and refused while wallets hold it rather than cascading into their seeds
… ETH, USDT and every token added later share the account
…enLocked is a call privilege, granted for the call and dropped after
…esolver for the direct shortcut and both fallbacks, and an error that names the hop count
…o the VPN control, with copy
… vpn-client to exit before starting the next
…mand hook only runs at min_hops=1, so route setup is skipped before the finder is asked
…2/3-hop routes on it — a visor with no transports cannot route through anything
… exists in the WebView but silently returns nothing without its Play module
…und-trips can't zero it; phone dials client apps over 2 mux routes by default
… restart caveat on hv add, remote-diagnosis session, and what of it reaches the Android visor; regen stale command reference
…], and the visor's dmsg RPC surfaces no longer die with a blank cli_addr, so --via reaches a phone
…mote-management grant/revoke are buttons rather than text links
…ty settings and Not now were text links among pills
…sing the header ⋮ the moment it opened, and gutting the message sheet's staged menuix(mobile): one button style for settings card actions — Open security settings and Not now were text links among pills
…nder-owned, probe-propagated), no self/on-screen notifications (focus lease + per-thread tags), VPN handoff socket leak, custom min-hops tile, member-dialog spacing
…behind it configures the room as much as it lists people, so it splits into Settings and Members sections, titles itself for what it edits (Group/Channel), and hides a section header with nothing under it fix(skychat): the avatar confirm was opening behind group settings — it is a dialog opened from a dialog, so it takes an explicit z-index above the overlay layer instead of relying on DOM order, which had only ever worked because every earlier caller sat above it in the file
…ct's cadence — registration-over-CXO stretches a no-change re-registration to 30m, so the 10m bound rejected settled visors as stale and every transport test read it as visor-b not found in DMSG discovery
… router, networker and config, so skipping it for 1 left every later plain 'proxy start' inheriting a previous --mux 2 across restarts, and visorC's mux_routes:2 contradicted the two tests that document mux as disabled
…ead of trusting min_hops=2 alone — route setup was building a 1-hop route over a leftover SUDPH transport that cannot carry traffic in Docker E2E, so skysocks-client flapped against the route-group handshake window
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check? YesFixes: #3822
Changes:
Fixes for the tester reports collected on Telegram, plus the follow-ups Moses raised on the routing thread.
Skychat
0ac1c6897)8e6303ff6)81b4779e7)d802fe925)Calls / lifecycle
07327b17a), pinned by an instrumented test (1462355d6)4a028fadb)Wallet
6dcc7eba0)b1a696f2f)VPN / routing
d35b1de0d)6b333c1b3)83edcc2f9)df75bb43f); the toggles no longer fight the poll, and a new vpn-client waits for the old one to exit (819afddc9)66810a158)Remote diagnosis
--via— trust model, hypervisor attach vs the full bridge, the two-terminal diagnosis session; stale generated CLI reference regenerated (8cc9e91db)cli_addrno longer disables the visor's whitelist-gated dmsg RPC surfaces — soskywire cli --via dmsg://<phone>works end to end (989bdce26)