feat(cli): drop the web browser-UI command from the default binary - #4039
Merged
Conversation
The default skywire binary (repo-root main -> cmd/skywire-cli/commands) registered the `web` command, which served the CLI as a browser UI and embedded cmd/skywire/commands/web/static/b.wasm (~111 KB) unconditionally into both the repo-root binary and ./cmd/skywire. The command is redundant: the CLI/cobra help tree is already reachable via the websh terminal in the hypervisor UI and the wasm-visor UI. Remove it from the command tree and delete the self-contained package (server, its own wasm/main.go source, and static/ assets incl. b.wasm). - cmd/skywire-cli/commands/root.go: drop the import, the GroupID line, and the AddCommand entry. - cmd/skywire/commands/web/: removed entirely (self-contained; no other Go package imported it, and its wasm builder is not shared with any other tooling). - Makefile build-wasm lane: drop ./cmd/skywire/commands/web/wasm from the compile-check list. - docs: drop the command's README and its index entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
webcommand (skywire cli web/skywire web) from the default command tree and deletes its self-contained package.The default skywire binary (repo-root
skywire.go->cmd/skywire-cli/commands) registeredweb, which served the CLI as a browser-based UI and embeddedcmd/skywire/commands/web/static/b.wasm(~111 KB) unconditionally into both the repo-root binary and./cmd/skywire.Why
The command is redundant: the cobra/CLI help tree is already reachable interactively via the websh terminal in the hypervisor UI and the wasm-visor UI. Dropping it removes the unconditional
b.wasmembed from the default binary.Changes
cmd/skywire-cli/commands/root.go: remove thewebimport, itsGroupIDassignment, and theAddCommandentry.cmd/skywire/commands/web/: deleted entirely. It was self-contained — no other Go package imported it (grep -rn "commands/web" --include=*.gofinds only this registration), and itswasm/main.gob.wasm builder is not shared with any other tooling.Makefile: drop./cmd/skywire/commands/web/wasmfrom thebuild-wasmcompile-check lane.docs/skywire/web/README.mdand its index entry indocs/skywire/README.md.Verification
go build .(repo root) — passes.go build ./cmd/skywire— passes.go list -deps . | grep commands/web— empty (the package, and thusb.wasm, is no longer in the default binary).go vet ./cmd/skywire-cli/commands/— clean.