Revert "consolidate tp-list onto the telemetry feed (#4171)" - #4174
Merged
Conversation
…in#4171)" Reverts skycoin#4171. On a busy hub (my dev visor, ~750-1271 live transports) TPD stopped agreeing after the visor moved to the combined feed: its transport count churned at ~15-30% of live and TPD showed no aggregator activity for that visor's PK — the combined-feed subscribe/fetch did not land for the large Root, while the dedicated tiny tp-list Root filled completely (1271=1271) before. The consolidation works for normal visors (the port-50 targeted fetch landed for ~143) but regresses large hubs, and TPD's global total dropped as the fleet adopted it, so restore the proven two-feed model until the busy-hub combined-feed path is fixed and verified. The connection-halving win will return once that's understood.
0pcom
added a commit
that referenced
this pull request
Aug 25, 2026
… connection) (#4184) The dedicated tp-list discovery feed (#4152, a second CXO node on DmsgVisorTPListCXOPort) meant every visor held TWO CXO connections to TPD — one per aggregator — doubling TPD's per-conn goroutines and the per-session dmsg handshake load on the dmsg servers. Publish the tp-list leaf on the telemetry feed by default so a visor holds ONE CXO node/conn to TPD. TPD needs no change: its port-50 aggregator's targeted discovery-leaf fetch already extracts the small tp-list leaf from the combined feed, and the port-69 aggregator keeps serving visors still on the dedicated feed during rollout. Safe to retry now that #4179 fixed the big-Root fill that forced the earlier revert (#4174 of #4171): the flat 90s whole-Root fill cap is replaced by a stall timer that resets on every fetched object plus a hard ceiling, so a large-but-progressing combined Root completes instead of breaking mid-fill. Measured churn on the busy dev hub dropped to ~0.86%/interval. Discovery itself does not wait on that fill — the targeted tp-list fetch lands the inlined leaf independently. Reversible: Stats.DedicatedTPListFeed=true restores the separate dedicated feed if a busy hub is ever seen under-filling on the combined feed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4171: on a busy hub (~750-1271 transports) TPD stopped agreeing after the visor moved to the combined feed — its count churned at ~15-30% of live and TPD logged no aggregator activity for that PK, while the dedicated tiny tp-list Root had filled completely (1271=1271) before. Works for normal visors but regresses large hubs and dropped TPD's global total. Restoring the proven two-feed model until the busy-hub combined-feed subscribe/fetch is understood and fixed.