Revert tp-list feed consolidation (#4184): busy-hub combined-Root fill undercounts TPD - #4189
Merged
Merged
Conversation
…isor↔TPD connection) (skycoin#4184)" This reverts commit d81b382.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4184. The consolidation defaulted the tp-list onto the big combined telemetry Root, but a busy hub's combined Root can't finish its fill — which is the exact reason the dedicated tp-list feed exists (see the deployed TPD's own note: the tp-list feed is "kept on its own node/port so a visor's tp-list Root never head-collides with its telemetry Root"; the telemetry aggregator only reconciles tp-list from the combined feed as a "back-compat fallback").
Observed live: a 851-transport visor (813 in / 38 out) was undercounted by TPD as ~184 — the combined-Root fill breaks so the fallback tp-list extraction is incomplete. This is the same failure that got the first attempt reverted; #4179 improved network-wide fill churn but did not make a busy hub's combined Root reliable enough to carry the tp-list.
Restores the always-on dedicated tp-list feed (
buildTPListPublisherunconditional; drops theDedicatedTPListFeedopt-out). Re-consolidation should wait until a busy hub's combined-Root fill is proven to reliably carry tp-list AND the deployed TPD is confirmed to extract it — migrated TPD-first, not visor-first.