fix(proxystatus): fixed-width leg metrics so the tree doesn't shift on updates - #4203
Merged
Merged
Conversation
…n updates The route tree's left per-route summary sized its route-rtt and ↑/↓ byte columns from the per-snapshot max, so as the live values streamed over the WebSocket (~1s) changed digit count the columns — and the box-drawing branch and PK to their right — jumped horizontally. Pin those mutable fields to fixed monospace widths (rtt 6, bandwidth 7) and add font-variant-numeric:tabular-nums to pre.bitree, so a value crossing 1ms→342ms→1203ms or 9B→2.4K→15.3M no longer reflows the tree. The R[n] identity width stays measured since it is structural.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status.skysocks route tree sized its route-rtt and ↑/↓ byte columns from the per-snapshot max, so as the live values streamed over the WebSocket (~1s) gained or lost a digit the columns — and the box-drawing branch and PK to their right — jumped horizontally.
Pin those mutable fields to fixed monospace widths (rtt 6, bandwidth 7) in the Go label builder and add
font-variant-numeric:tabular-numstopre.bitree, so a value crossing 1ms→342ms→1203ms or 9B→2.4K→15.3M no longer reflows the tree. TheR[n]identity width stays measured since it is structural (changes only when a route is added or dropped).