feat(proxy): split status.skysocks goodput up/down + per-direction share bars + direct-leg rtt fix - #4232
Merged
Merged
Conversation
…re bars, fix direct-leg rtt status.skysocks route tree + 'proxy tree': - Goodput split into per-direction rates (goodput_up_bps / goodput_down_bps, sampled separately in snapshotLegs; goodput_bps kept as the sum) shown next to the up/down byte totals instead of one combined column. Also fixes the CLI 'proxy tree' path, which dropped goodput entirely. - Per-direction bandwidth-SHARE bars (████░, fixed width) restored — this route's fraction of the route-group aggregate up-/down-goodput. The original share bars lived in the pre-skycoin#4137 mux table; re-added in the shared RouteTree so CLI and HTML stay unified. - Direct-leg latency: hop-0 now shows the live E2E route rtt for a direct leg instead of tp.GetLatency()'s RAW last 60s-cadence sample (SetLatency overwrites Avg with no EWMA), which made the transport rtt disagree with the smoothed route rtt for up to a minute. tp.GetLatency() is left untouched for route-finder / tp ls / policy scoring; multihop legs keep the near-edge transport RTT on hop 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three status.skysocks route-tree refinements (also
skywire cli proxy tree):goodput_up_bps/goodput_down_bpssampled separately (sum kept asgoodput_bps), shown next to the ↑/↓ byte totals instead of one combined column. Also restores goodput on the CLIproxy tree, which had dropped it.████░fixed-width meters showing each route’s fraction of the route-group aggregate up-/down-goodput. These existed in the pre-feat(proxystatus): fold per-leg mux table + full routes into one route tree #4137 mux table and were lost in the route-tree unification; re-added in the sharedRouteTreeso CLI and HTML stay unified.tp.GetLatency()returns the RAW last sample from a 60s ping (SetLatencyoverwritesAvgwith no EWMA), so one unlucky sample stuck for a minute. Hop-0 now shows the live E2E route rtt for a direct leg;tp.GetLatency()is untouched for route-finder/tp ls/policy scoring, and multihop legs keep the near-edge transport RTT on hop 0. Developed with AI assistance (Claude).