fix(lint): rf/store test compile break + datagram/gosec/gofmt - #4235
Merged
Conversation
… gosec/gofmt - pkg/deployment/rf/store test mockStore was missing GetTransportSummary, so the package's test binary failed to COMPILE (CI-blocking typecheck failure) — add it. - datagram_route_group SA4023: drop the always-true 'want != nil' (RemoteAddr never returns a nil interface). - init.go dmsg-server shuffle: justified //nolint:gosec (non-crypto load shuffle). - gofmt reorder_test.go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears CI lint/compile failures found by a full-repo
golangci-lint run ./...:pkg/deployment/rf/store— the testmockStorewas missingGetTransportSummary, so the package test binary failed to compile (a CI-blockingtypecheckfailure). Added the method.datagram_route_group.goSA4023 — dropped the always-truewant != nil(RemoteAddrnever returns a nil interface).init.go— justified//nolint:gosecon the dmsg-server shuffle (non-crypto load distribution).reorder_test.go.A follow-up PR will clear the remaining unrelated lint debt (errcheck/misspell/staticcheck/unparam). Developed with AI assistance (Claude).