SK-3118: Restore python-dotenv dependency (fixes broken 1.0.0 import) - #280
Merged
Merged
Conversation
The bundled common/ module (common/utils/_utils.py) imports `dotenv`, so `python-dotenv` is a runtime dependency of the flowvault wheel. It was dropped during the bulk removal on the mistaken belief that only the deleted utils/_batching.py used it — but common is vendored into the wheel and needs it. As a result a clean `pip install skyflow-flowvault-python` fails at `import skyflow` with `ModuleNotFoundError: No module named 'dotenv'`. Re-add `python-dotenv >= 1.1.0, < 2` (matching skyvault, which kept it). Verified: the rebuilt wheel declares the dep, and a clean-venv install imports `skyflow` successfully. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Build the wheel, install ONLY that wheel into a fresh virtualenv, and import skyflow from outside the repo. The venv has just the wheel's declared runtime dependencies, so a dependency missing from setup.py (like the python-dotenv drop that broke 1.0.0) fails the import here. The existing unit-test job installs dev deps, which masked this class of bug. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Before publishing to PyPI or JFrog (and even on a dry run), install each freshly built artifact — wheel and sdist — into its own clean virtualenv and import it from outside the repo. A missing runtime dependency in setup.py or a non-self-contained sdist now fails the release job before anything is uploaded, instead of shipping a broken artifact (as happened with 1.0.0's dropped python-dotenv). Applies to both skyvault and flowvault releases. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
skyflow-bharti
approved these changes
Sep 16, 2026
yaswanth-pula-skyflow
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
skyflow-flowvault-python==1.0.0fails to import on a clean install:Root cause
The bundled
common/module (common/utils/_utils.py) importsdotenv, sopython-dotenvis a runtime dependency of the flowvault wheel. It was dropped during the bulk removal on the assumption that only the deletedutils/_batching.pyused it — butcommonis vendored into the wheel and needs it too. skyvault kept the dependency; flowvault should too.Not caught earlier because every local/CI environment already had
python-dotenvinstalled (via skyvault or dev extras), so the missing declaration only surfaces on a genuinely clean install (e.g. a freshpip installfrom PyPI).Fix
Re-add
python-dotenv >= 1.1.0, < 2toflowvault/setup.py.Verification
METADATAnow listsRequires-Dist: python-dotenv<2,>=1.1.0.pip install <wheel>pulls inpython-dotenv, andimport skyflowsucceeds.Follow-up
PyPI 1.0.0 is immutable and broken, so this needs a 1.0.1 release (tag
flowvault/v1.0.1), and 1.0.0 should be yanked on PyPI sopip installskips it.