feat: resolve image URL from registry hierarchy in deployment matrix - #5
Closed
nadaverell wants to merge 1 commit into
Closed
feat: resolve image URL from registry hierarchy in deployment matrix#5nadaverell wants to merge 1 commit into
nadaverell wants to merge 1 commit into
Conversation
- Add registry, image, and per-env registry fields to SkyhookConfig, SkyhookService, and SkyhookEnvironment - Add standalone resolveImage() in matrix-builder implementing the hierarchy: service.image > env.registry > root registry - buildMatrixFromSkyhook accepts rootRegistry and populates image per entry - processSkyhookConfig passes config.registry as rootRegistry - image field included in DeploymentEntry and toObject() output - Add tests: resolveImage unit tests, buildMatrixFromSkyhook with registry integration suite (20 tests total, all passing)
Contributor
Author
|
Discarding this approach — registry belongs in Kustomize overlays per ADR, not in skyhook.yaml. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registry, per-serviceimage, and per-envregistryfields toSkyhookConfig,SkyhookService, andSkyhookEnvironmentresolveImage()inmatrix-builder.jsimplementing the three-level hierarchy:service.image>env.registry/name>rootRegistry/namebuildMatrixFromSkyhookacceptsrootRegistry(read fromconfig.registryinindex.js) and populatesimageper service×env entryDeploymentEntrynow carries animagefield included intoObject()outputresolveImageunit tests andbuildMatrixFromSkyhook with registryintegration suiteContext
Fixes the root cause of broken CI pipelines:
build_image.ymlpassesimage: ${{ matrix.image }}tocloud-loginanddocker-build-push-action, but the matrix never had animagefield. Now it does.The resolved
imagecomes from the registry hierarchy defined in.skyhook/skyhook.yaml— no registry logic belongs in customer workflow files.Related:
KoalaOps/koala-backendPR (schema + service creation),KoalaOps/orbit(already merged — org-settings API + CI fix).