feat: enhance output configuration for Docker action - #1
Open
hisco wants to merge 1 commit into
Open
Conversation
- Updated `load` input description to allow combination with `push`. - Introduced new `outputs` input for specifying output destinations, with automatic configuration when both `push` and `load` are true. - Added validation for `outputs` compatibility with `push` and `load` settings in the action's logic. - Expanded README with detailed usage examples for output configurations.
nadaverell
reviewed
Nov 19, 2025
| echo "📝 Tags to build:" | ||
| printf "%s\n" "$TAGS" | sed 's/^/ - /' | ||
|
|
||
| - name: Prepare outputs configuration |
Contributor
There was a problem hiding this comment.
a bit confusing... hope you're sure about the logic here
nadaverell
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eventually I didn't need to load and publish as I was able to publish to multiple registry so we have this change which was tested and now is nice to have and make sense.
it doesn't break current interface and will effective only if used.
loadinput description to allow combination withpush.outputsinput for specifying output destinations, with automatic configuration when bothpushandloadare true.outputscompatibility withpushandloadsettings in the action's logic.