fix(installer): avoid GitHub API rate-limit failures - #1198
Open
nadaverell wants to merge 3 commits into
Open
Conversation
nadaverell
force-pushed
the
fix/installer-latest-release-lookup
branch
from
August 3, 2026 08:47
d71e532 to
eee2f51
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 77f9bc8. Configure here.
nadaverell
force-pushed
the
fix/installer-latest-release-lookup
branch
from
August 5, 2026 15:05
77f9bc8 to
0e69f0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
The public bootstrap could download successfully and then fail at
Fetching latest release.... Both installers discovered the latest tag through the unauthenticated GitHub REST API, whose per-IP quota is shared by users behind the same corporate NAT, VPN, or CI egress.This changes only bootstrap release discovery. The POSIX and PowerShell installers now use the ordinary GitHub latest-release redirect and no longer depend on that REST quota.
Mechanism
Both installers request:
They follow the redirect, require its final destination to be the exact HTTPS Radar release-tag path, validate the tag as semantic-version syntax, and then construct the existing versioned release-asset URL. Unexpected hosts, paths, ports, credentials, query strings, fragments, or tag formats fail before a temporary directory or download is created.
install.shreads curlurl_effectiveand compares the complete final URL.install.ps1reads the final response URI using the respective Windows PowerShell 5.1 and PowerShell 7 response shapes.api.github.comdiscovery in either bootstrap script.There is deliberately no fallback to
releases.skyhook.io. Bootstrap only needs a tag, and using the GitHub redirect avoids adding first-party service availability or update telemetry to the initial install path. The in-product update resolver and desktop updater have different metadata requirements and are outside this change.Publication boundary
Merging this PR does not create a Radar tag, binary release, image, chart, or package-manager artifact. However, the public
get.radarhq.ioendpoints serve the installer files frommain, so merging is a live installer publication after the existing cache window. Rollback is a revert onmainand the same cache propagation path.How to test each request
1. Bootstrap script delivery
curl -fsS https://get.radarhq.io -o /tmp/radar-install.sh sh -n /tmp/radar-install.sh grep -F github.com/skyhook-io/radar/releases/latest /tmp/radar-install.sh ! grep -Fq api.github.com /tmp/radar-install.shExpected: HTTP 200, valid shell syntax, the browser-facing latest-release URL is present, and the REST API hostname is absent.
2. Latest-tag discovery
curl -fsSL -o /dev/null \ -w "status=%{http_code}\neffective_url=%{url_effective}\n" \ https://github.com/skyhook-io/radar/releases/latestExpected: HTTP 200 and an effective URL of
https://github.com/skyhook-io/radar/releases/tag/v<version>.3. Versioned release asset
Expected: GitHub returns the release-asset redirect. Substitute the target OS and architecture as needed.
4. Complete installers
The
Installer smoke testsworkflow runs the checked-out scripts end to end on Ubuntu, Windows PowerShell 5.1, and PowerShell 7, then executes the installedkubectl-radar --version. Use a disposable host if testing the public script manually because it writes to the normal system/user install location.Validation
sh -n install.shv1.9.0v1.9.0macOS arm64 asset responsemake tscmake testmake buildScope
This PR does not change install destinations, command aliases, artifact verification, the in-product update checker, the desktop updater, or any release/publishing workflow.
Type of change