feat: add minimal runtime service registry seam#135
Merged
Conversation
Owner
Author
|
SR9 overlap repair pushed at
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
RuntimeOnlyServiceRegistrymarker while still implementingRuntimeServiceRegistryTypeErrorbehavior without claiming blanket pickle refusal for arbitrary unmarked third-party objectsVerification
ImportError: cannot import name 'RuntimeOnlyServiceRegistry'(1 error, exit 2)uv run pytest -q tests/test_runtime_services_contract.py tests/test_engine.py tests/test_runner_v2_recovery.py tests/test_types.py(39 passed)uv run pytest -q(462 passed, 2 skipped)git diff --check: cleansrc/hermes_workflows/runtime_services.py,src/hermes_workflows/engine.py,src/hermes_workflows/types.py,tests/test_runtime_services_contract.pyBase and amendment receipt
0e86026e2688466056d3fdcc7d3249ed9f685b75origin/mainat2727a46b1a799a4a2125d3b85e292db514f1fb98without consuming stale PR feat: support custom select values in review queue #131adbf605c201edd3839864357b7c51ddfd17aac483d65b30324b52dfd4b7de3044bddf9e7e63339c439bf53b27f603466ec6cf72b