HW-16: ship and manage the dashboard plugin payload#152
Merged
Conversation
Owner
Author
|
HW-16 macOS real-temp-root successor pushed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HW-16 contract
Ships the issue-owned, wheel-canonical dashboard plugin payload source and a profile-scoped lifecycle manager. This PR does not edit package metadata, CLI registration, tracked top-level plugin sources, runtime core, or live Hermes profiles.
7ba36f01abf98bb60a43f4df07e4b9230e46c0d7351d28e76cd00e05bfb5bfbb1a2fc40187a2e063remediation/hw-16Exact paths
src/hermes_workflows/plugin_install.pysrc/hermes_workflows/plugin_payload/hermes-workflows-approvals/plugin.yamlsrc/hermes_workflows/plugin_payload/hermes-workflows-approvals/__init__.pysrc/hermes_workflows/plugin_payload/hermes-workflows-approvals/dashboard/manifest.jsonsrc/hermes_workflows/plugin_payload/hermes-workflows-approvals/dashboard/plugin_api.pysrc/hermes_workflows/plugin_payload/hermes-workflows-approvals/dashboard/dist/index.jssrc/hermes_workflows/plugin_payload/hermes-workflows-approvals/dashboard/dist/style.csstests/test_plugin_install.pytests/probes/fresh_profile_plugin.pytests/fixtures/plugin_manifest_v1.jsongit diff --name-only 7ba36f01...HEADequals this closed ten-path allowlist.pyproject.toml,src/hermes_workflows/cli.py,plugins/**, runtime core, docs, and.hermes/showcase-artifacts/**are unchanged.Behavior
0.0.1rc1)plugin_api.pyThe payload
__init__.py, API, JS, and CSS are byte-identical to the current tracked top-level sources. Issue-owned payload manifests carry the package version; top-level canonicalization remains deferred to its named adapter.TDD and verification
Red observed before implementation:
uv run pytest -q tests/test_plugin_install.pyImportError: cannot import name 'plugin_install' from 'hermes_workflows'Green receipts:
16 passed in 0.73s16 passed in 0.42s691 passed, 2 skipped in 41.59s0.0.1rc1→ discover manifest/API/JS/CSS routes → rollback to0.0.1rc0→ uninstall;profile_removed=true,live_profile_mutated=falsepython -m py_compile: passgit diff --check 7ba36f01...HEAD: passcmpchecks for__init__.py,plugin_api.py,dist/index.js, anddist/style.css: passFocused tests cover atomic promotion failure restoring the previous install, interrupted rollback/uninstall recovery, ownership-scoped uninstall, retained rollback, config enablement, restart/rescan reporting, version parity, manifest/API/JS/CSS discovery, traversal/symlink refusal, stale/corrupt receipts, modified/user-owned file refusal, and fresh-profile lifecycle discovery.
Deferred adapter gates — intentionally not claimed here
A read-only wheel probe on this head proves the current package adapter is not complete:
dashboard/dist/index.jsanddashboard/dist/style.cssare absent without the shared package adapter.plugin_payload_manifest.v1.jsonremains the FND-PKG empty manifest (files: []).INT-PKG-METAowns wheel metadata/resource-manifest inclusion.INT-PKG-ASSETSowns top-level-source canonicalization and generated asset packaging.INT-PKG-CLIowns CLI registration.Accordingly, this PR does not claim built-wheel installation or fresh-wheel discovery. It supplies the issue-owned module/payload contract those adapters consume.
Safety receipt
All lifecycle tests and the probe used temporary profile roots. No Palmer/default profile, plugin registry, workflow DB, service, cron, credential, dashboard process, or live installation was read for mutation, changed, restarted, or reconfigured.
Do not merge before the controller-owned fresh specification review and separate quality/security review.