fix(test): stop asserting concurrency via a wall-clock threshold - #566
Merged
Conversation
Two tests inferred concurrency from `elapsed < sequential_estimate * 3 / 4` (100ms-per-operation fixtures). That's only ever true relative to how fast the machine happens to be that run: on a loaded/throttled GitHub-hosted Windows runner, thread::sleep(100ms) itself can take several hundred milliseconds of wall-clock time, which pushes *both* the sequential and concurrent paths past any fixed absolute threshold. Hit for real in release PR #564's merge-queue run: elapsed 889ms vs. a 600ms "fully sequential" estimate -- worse than fully sequential, which is only possible under uniform scheduling overhead, not an actual concurrency regression (the dispatch code was independently re-verified: `emit::read_and_emit_all_candidates` and `workflow::enumerate_all_roots_concurrently` both still spawn one thread per lease/root via `std::thread::scope`). Replace the wall-clock-ratio assertion with direct proof: record every operation's (start, end) Instant and assert at least two intervals overlap. Two things overlapping in time is true or false independent of how slow the machine is -- it only asks whether they ran at the same time, which is what "concurrent" actually means. Verified 15/15 consecutive local runs; xwin cross-compile clean; lint-tests (pedantic + nursery) clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two `uffs-content` tests inferred concurrency from
`elapsed < sequential_estimate * 3 / 4` against 100ms-per-operation
fixtures. That threshold is only meaningful relative to how fast the
test machine happens to be that run — on a loaded/throttled
GitHub-hosted Windows runner, `thread::sleep(100ms)` itself can take
several hundred milliseconds of wall-clock time, pushing both the
sequential and concurrent paths past any fixed absolute threshold.
Hit for real in release PR #564's merge-queue run: elapsed 889ms vs. a
600ms "fully sequential" estimate — worse than fully sequential, which
is only possible under uniform scheduling overhead, not an actual
concurrency regression. I independently re-verified the dispatch code:
`emit::read_and_emit_all_candidates` and
`workflow::enumerate_all_roots_concurrently` both still spawn one
thread per lease/root via `std::thread::scope`.
Fix
Replace the wall-clock-ratio assertion with direct proof: record every
operation's (start, end) `Instant` and assert at least two intervals
overlap. Two things overlapping in time is true or false independent
of how slow the machine is.
Test plan