Skip to content

Rename CLI command to OpenSkald#2

Merged
skyloevil merged 5 commits into
mainfrom
codex/rename-openskald
Jun 2, 2026
Merged

Rename CLI command to OpenSkald#2
skyloevil merged 5 commits into
mainfrom
codex/rename-openskald

Conversation

@skyloevil

@skyloevil skyloevil commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • rename the CLI entry point from openviking-agent to OpenSkald
  • update README, architecture docs, and helper scripts to call uv run OpenSkald
  • keep OpenViking project, knowledge base, config, classes, and module names unchanged

Verification

  • uv run pytest
  • uv run ruff check .
  • scripts/check.sh

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a comprehensive renaming of the project from 'OpenViking' to 'OpenSkald' across all documentation, configuration files, environment variables, CLI commands, Docker setups, and source code. The review feedback highlights two important issues in backend/app/config/settings.py: a path validation vulnerability where empty or relative dot paths can bypass existence checks and glob the entire project directory, and a configuration loading issue where explicitly specified configuration paths that do not exist are silently ignored instead of raising an error.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread backend/app/config/settings.py Outdated
Comment thread backend/app/config/settings.py
@skyloevil skyloevil changed the title Rename project to OpenSkald Rename CLI command to OpenSkald Jun 2, 2026
@skyloevil skyloevil self-assigned this Jun 2, 2026
@skyloevil skyloevil merged commit 0c2ffe8 into main Jun 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant