fix: Potential fix for code scanning alert no. 11: Uncontrolled data used in path expression

[skyoo2003]

Potential fix for https://github.com/skyoo2003/devcloud/security/code-scanning/11

Use defense-in-depth in internal/services/s3/store.go by validating each untrusted path component before constructing filesystem paths.

Best fix (without changing intended functionality):

1. Add a helper that rejects unsafe path parts:
   • empty parts
   • ".", ".." components
   • any path separator (/ or \) inside a single component
2. In safePath, validate every entry in parts with that helper before filepath.Join.
3. Keep existing clean/join + baseDir containment check as a second layer.

This ensures bucket/accountID remain single components and key cannot inject traversal segments. It prevents tainted user path input from reaching filesystem APIs in dangerous form.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a defense-in-depth path component validator to the S3 file store and integrates it into safePath to prevent unsafe/uncontrolled path segments from being used in filesystem operations while preserving the existing baseDir containment check.

File-Level Changes

Change	Details	Files
Introduce strict validation for individual path components before constructing filesystem paths.	Add validatePathPart helper to reject empty, dot, dot-dot, or separator-containing path components Use validatePathPart on every argument to safePath before calling filepath.Join Preserve existing baseDir-anchored join and filepath.Clean containment check as a second protection layer	internal/services/s3/store.go

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Validating every safePath part with validatePathPart will reject keys that contain intended subdirectories (e.g. foo/bar) or empty segments, which may be valid in the current API; consider limiting this validation to bucket/accountID or splitting the key into components and validating each segment instead of forbidding all separators in the raw key.
• By hard-rejecting "." and ".." as path parts, you may be disallowing currently valid object names that happen to be exactly these strings; if those are allowed today, adjust the validation to only treat them as dangerous when they appear as traversal components inside a longer path.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Validating every `safePath` part with `validatePathPart` will reject keys that contain intended subdirectories (e.g. `foo/bar`) or empty segments, which may be valid in the current API; consider limiting this validation to bucket/accountID or splitting the key into components and validating each segment instead of forbidding all separators in the raw key.
- By hard-rejecting `"."` and `".."` as path parts, you may be disallowing currently valid object names that happen to be exactly these strings; if those are allowed today, adjust the validation to only treat them as dangerous when they appear as traversal components inside a longer path.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}