fix: Potential fix for code scanning alert no. 8: Uncontrolled data used in path expression

[skyoo2003]

Potential fix for https://github.com/skyoo2003/devcloud/security/code-scanning/8

General fix: validate untrusted path components before filesystem use, and enforce robust path containment checks with normalized absolute paths and filepath.Rel (instead of simple prefix checks).

Best concrete fix here:

1. In internal/services/lambda/store.go, harden codePath:
   • reject invalid functionName/accountID components (empty, ".", "..", any path separator),
   • resolve absolute base and candidate paths with proper error handling,
   • verify candidate is within base using filepath.Rel and reject if rel == ".." or starts with ".."+sep.
2. Keep existing behavior (same resulting code.zip location) for valid names.
3. No provider routing behavior changes required.

This addresses the CodeQL flow at the sink while preserving functionality for normal Lambda function names.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

[sourcery-ai]

Reviewer's Guide

Hardens Lambda function code path construction to prevent path traversal by validating path components and enforcing containment using normalized absolute paths and filepath.Rel.

File-Level Changes

Change	Details	Files
Harden Lambda code zip path construction and add reusable path component validation.	Add validation of account ID and function name to reject empty, dot, dot-dot, or values containing path separators before building the path. Replace best-effort absolute path resolution (ignoring errors) with checked filepath.Abs calls for both the base code directory and the computed code path, returning wrapped errors on failure. Use filepath.Rel between the absolute base directory and candidate path to ensure the resulting path is contained within the base, rejecting traversal when the relative path is '..' or starts with '..'+separator. Introduce a small helper function to encapsulate safe path component checks for reuse and clarity.	internal/services/lambda/store.go

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}