DOC: Add ellipticity example#471
Conversation
Lucia-Fonseca
added
documentation
Lucia-Fonseca
changed the title
|
Review comments addressed. |
rrjbca
left a comment
rrjbca
left a comment
There was a problem hiding this comment.
Some general comments:
- Calculating the variance from multiple simulations overcomplicates the code and distracts from the main purpose of the example. I would stick to just a single simulation as in our other examples.
- What is the source of the SDSS data? How was the file generated? Are we licensed to distribute it?
| # projected 2D axis ratios. Specifically, it samples the axis ratios of the | ||
| # 3D ellipsoid according to the description above [1] and | ||
| # then randomly projects them using | ||
| # :func:`skypy.utils.random.triaxial_axis_ratio()`. |
There was a problem hiding this comment.
Potentially confusing to mention the triaxial_axis_ratio function. It is hidden from the user who doesn't need to understand the implementation in this context.
There was a problem hiding this comment.
Not sure I agree, but I'm open to delete that bit.
There was a problem hiding this comment.
To be clear, we still want to explain the model (population of triaxial ellipsoids with some distribution in projection) but the implementation details (ryden04_ellipticity calls another function triaxial_axis_ratio) are at best irrelevant and at worst confusing for the user.
| lw=0.5, mew=0.5, label='SkyPy model') | ||
|
|
||
| plt.xlabel(r'Axis ratio, $q_{am}$') | ||
| plt.ylabel(r'N') |
There was a problem hiding this comment.
Units? Do we know the area covered by the data?
There was a problem hiding this comment.
yes it's axis ratio and number of galaxies, the area shouldn't come into it
Yes, I agree. However, how could you generate the error bars otherwise? Or you are suggesting we simply draw one sim and plot the histogram? How can we convince the SkyPy model is compatible with SDSS data?
|
No, I queried the data from the SDSS servers because I didn't know. |
4 participants
Description
This PR includes the validation plot for the 3D ellipticity model (Ryden04) in the examples page.
It reproduces the distribution of axis ratio
𝑞_{am}for exponential galaxies in the SDSS DR1 as done by @ntessore here.Merging this PR closes #470.
Checklist
References