Skip files that cannot be read - #15
Open
gardockt wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a simple
IOExceptionhandling toreadBytesmethod call - when the exception is thrown, a warning is logged and the file is skipped.By the way, I'm not sure if this is intentional, but after reading the bytes
InputStream.closemethod is called, which apparently does nothing. I left it in case this is intentional, so that this stream does not appear to be left open.Partially fixes issue #5 - at the moment of writing this, there are two known exceptions that cause the crash (1 and 2), and this PR addresses the first one.