You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you very much for your interest in the project.
The issue of potentially ongoing activities during shutdown has indeed caught my attention. However, I believe that attempting to use locks during "acquisition" without considering the specific use cases does not adequately address this problem.
There are two viable approaches:
My personal preference is to implement lock-free reference counting during processing and wait during shutdown.
An alternative method could be to use read-write locks, allowing multiple simultaneous operations while permitting shutdown to occur in only one place. However, this approach would require simulation to determine if the implementation is reasonable and if the performance impact falls within acceptable limits.
I'm very much looking forward to discussing these aspects with you and conducting more test cases and simulations to confirm the feasibility of the relevant processes.
Once again, thank you for your interest in this matter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a possible data race between
ShutdownandServeNextRequest