Skip to content

Check on which date rates were updated #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devsli wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check on which date rates were updated #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/nbrb_currency.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ class NbrbCurrency < Money::Bank::VariableExchange
NBRB_RATES_URL = 'http://nbrb.by/Services/XmlExRates.aspx'
CURRENCIES = %w(AUD BGN UAH DKK USD EUR PLN IRR ISK JPY CAD CNY KWD MDL NZD NOK RUB SGD KGS KZT TRY GBP CZK SEK CHF)

attr_reader :rates_updated_on

def update_rates(cache=nil)
exchange_rates(cache).each do |exchange_rate|
rate = exchange_rate.xpath("Rate").text
Expand Down Expand Up @@ -49,6 +51,7 @@ def exchange_with(from, to_currency)
def exchange_rates(cache=nil)
rates_source = !!cache ? cache : NBRB_RATES_URL
doc = Nokogiri::XML(open(rates_source))
@rates_updated_on = Date.strptime(doc.xpath('DailyExRates/@Date').text, '%m/%d/%Y')
doc.xpath('DailyExRates//Currency')
end

Expand Down
5 changes: 5 additions & 0 deletions spec/nbrb_currency_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,4 +97,9 @@
@bank.add_rate("BTC", "USD", 13.7603)
expect(@bank.exchange(100, "BTC", "USD").cents).to eq(138)
end

it "should tell on which date rates were updated" do
@bank.update_rates(@cache_path)
expect(@bank.rates_updated_on).to eq(Date.new(2015, 4, 8))
end
end