Add retry/backoff and request timeout to HTTP requests#21
Merged
Conversation
- Add create_session_with_retries() helper using urllib3 Retry strategy - Retry on 429, 500, 502, 503, 504 with exponential backoff - Overpass API uses higher backoff_factor (10s) due to rate limiting - All requests now have a 120s timeout to prevent indefinite hangs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds resilient HTTP behavior to the update.py data-fetch workflow to reduce failures/hangs caused by transient network/server issues (especially Overpass API rate-limiting).
Changes:
- Introduces a
create_session_with_retries()helper usingrequests+urllib3.Retry. - Applies retries/backoff to OPSI downloads and Overpass API calls (with higher backoff for Overpass).
- Adds an explicit per-request timeout to avoid indefinite hangs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Overpass API is rate-limited and occasionally overloaded, causing the daily update workflow to fail with no retry. Additionally, all HTTP requests lacked a timeout, meaning a stalled connection could hang the workflow indefinitely until the 15-minute job timeout killed it.
This adds a
create_session_with_retries()helper that wrapsrequests.Sessionwith urllib3'sRetrystrategy:saveurl()(OPSI downloads) uses a standard backoff factor (2s base, sleeping 2s/4s/8s) for GET requestsNo new dependencies are introduced --
urllib3is already bundled withrequests.