Maintenance/increasing test coverage#148
Open
neumerance wants to merge 4 commits into
Open
Conversation
neumerance
force-pushed
the
maintenance/increasing-test-coverage
branch
5 times, most recently
from
cba402b to
304d3ee
Compare
neumerance
force-pushed
the
maintenance/increasing-test-coverage
branch
from
304d3ee to
a1e77f6
Compare
neumerance
changed the title
ingnam
reviewed
Jun 12, 2025
| end | ||
| resources :flags, only: [:index, :show, :create] | ||
| resources :transcript_speaker_edits, only: [:create] | ||
| resources :flags, only: [:index, :show, :create, :update, :destroy] |
There was a problem hiding this comment.
Check if update and destory methods are being used at all
Collaborator
Author
There was a problem hiding this comment.
action exists. I want to keep this work black box approach as possible.
|
|
||
| describe "GET #edit" do | ||
| it "assigns the transcription_convention and renders edit" do | ||
| get :edit, params: { institution_id: institution.id, id: transcription_convention.id } |
There was a problem hiding this comment.
Make your tests DRYer wherever possible:
e.g.
let(:valid_attributes) { attributes_for(:transcription_convention) }
let(:invalid_attributes) { { convention_key: "" } }
Collaborator
Author
There was a problem hiding this comment.
I dont see any advantage of doing this
IMO expecitly defining expect(assigns(:transcription_conventions)).to include(transcription_convention) for each tests involve is easier to read and much manageable than drying it out
neumerance
force-pushed
the
maintenance/increasing-test-coverage
branch
from
d6f8979 to
94fcfaa
Compare
ingnam
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR significantly increases the RSpec test coverage for the Amplify project, raising it from 47% to 80%.