fix(happy-cli): handle Windows PID reuse in daemon state check#809
Open
shenaibin789-glitch wants to merge 1 commit intoslopus:mainfrom
Open
fix(happy-cli): handle Windows PID reuse in daemon state check#809shenaibin789-glitch wants to merge 1 commit intoslopus:mainfrom
shenaibin789-glitch wants to merge 1 commit intoslopus:mainfrom
Conversation
On Windows, PIDs get reused after reboot. The daemon state check previously only verified if a PID was alive via process.kill(pid, 0), which could return true for a completely unrelated process that was assigned the same PID after a system restart. This adds an HTTP health check to the daemon's control server after the PID alive check. If the PID is alive but the HTTP ping fails, the stale state is cleaned up, allowing a fresh daemon to start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process.kill(pid, 0), which could returntruefor a completely unrelated process that happened to receive the same PID after a system restart.POST /list) to the daemon's control server after the PID alive check. If the PID is alive but the HTTP ping fails, the stale state file is cleaned up, allowing a fresh daemon to start.Test plan