fix(cli): close stateless Happy MCP server on response close#830
Open
liunice wants to merge 1 commit intoslopus:mainfrom
Open
fix(cli): close stateless Happy MCP server on response close#830liunice wants to merge 1 commit intoslopus:mainfrom
liunice wants to merge 1 commit intoslopus:mainfrom
Conversation
9795582 to
2d7329f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the built-in Happy MCP bridge for stateless HTTP mode by aligning its lifecycle with the MCP SDK example:
StreamableHTTPServerTransportper requestMcpServerper requestres.closeinstead of reusing them across requestsProblem
On Linux/NAS environments, Happy's built-in
mcp__happy__change_titletool could fail with errors like:No matching deferred tools foundNo such tool available: mcp__happy__change_titleThe root cause is that the stateless HTTP MCP implementation in
startHappyServerwas reusing a singleStreamableHTTPServerTransport(and connected MCP server state) across multiple HTTP requests.Why this fix
The MCP SDK's stateless Streamable HTTP example creates a new server/transport for each request and performs cleanup on response close. This PR makes Happy follow the same lifecycle pattern.
Validation
Tested on a Synology NAS / Linux environment where the bug was reproducible:
mcp__happy__change_titlefailed reliablyAlso discussed in #564.