Fix Codex mobile approval request handling#833
Open
SharingMan wants to merge 1 commit intoslopus:mainfrom
Open
Fix Codex mobile approval request handling#833SharingMan wants to merge 1 commit intoslopus:mainfrom
SharingMan wants to merge 1 commit intoslopus:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actionvaluesexec_approval_requestmetadata when Codex omits approval fields from the elicitation payloadapply_patch_approval_request/patch_apply_beginmetadata and cover both cases with testsTesting
node ../../node_modules/vitest/vitest.mjs run src/codex/__tests__/codexMcpClient.test.tscorepack yarn workspace happy-coder typecheck(fails on the current repo baseline with missing@slopus/happy-wiretypings / existingsessionProtocolexport errors, unrelated to this patch)