Added Draw Distance option to Display settings#446
Open
Mode8fx wants to merge 3 commits intosm64pc:nightlyfrom
Open
Added Draw Distance option to Display settings#446Mode8fx wants to merge 3 commits intosm64pc:nightlyfrom
Mode8fx wants to merge 3 commits intosm64pc:nightlyfrom
Conversation
Also changed applicable files to only import configfile if NODRAWINGDISTANCE is not used (otherwise it's an unused import)
Collaborator
|
Maybe it would be a good idea to eliminate NODRAWINGDISTANCE entirely later if we merge this. That could be its own separate PR though. |
Contributor
Author
|
Maybe, but it's not really hurting anything, either. |
Contributor
|
Nice I wanted something like this, because when you add a lot of high poly models with NODRAWINGDISTANCE sometimes it lags. What if the distance is set automatically based on the performance? it's posible? |
Contributor
Author
|
Maybe you could check what entities are in a level when you load it and how many polygons exist among these entities, then scale according to your hardware? No idea, maybe someone with a better understanding of loading that stuff could look into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new setting to the Display menu that lets you change the draw distance to anywhere between 0.5x and 5x the original game's draw distance, in 10% increments. This should be useful for weaker devices like a Raspberry Pi that can't handle the NODRAWINGDISTANCE build option. This option does not appear in the menu if NODRAWINGDISTANCE is used.
This was implemented by adding a new variable that is multiplied with every instance where an object's distance to Mario is compared in an "#ifndef NODRAWINGDISTANCE" define. Additionally, all of the original draw distances are divided by 100 since 100 represents a normal draw distance. The end result is the same, but this removes the need for continuous float multiplication where applicable (example: "2400.0f" becomes "24 * configDrawDistance", where configDrawDistance is an integer between 50 and 500, default=100).