Dhruv/migrate to scene delegate by dporwal-shipit · Pull Request #75 · smallcase/gw-mob-sdk-flutter

dporwal-shipit · 2026-05-14T20:24:36Z

No description provided.

…nes lookup

- Handle IMR_SETUP transaction result on Android - Add IMR_SETUP case to iOS IntentType enum and handle response - Expose IMR_SETUP constant in Dart ScgatewayIntent class - Bump Android SDK to 6.1.0, iOS SCGateway to 7.2.0

…currency errors

isouravganguly

[CRITICAL] smart_investing/pubspec.lock — scgateway was downgraded from 7.0.7 to 7.0.5 and scloans from 5.1.3 to 5.1.1. This looks like a branch-sync issue from an older base. These should be reverted to match master before merging.

Reply: This branch has een created from an older version of development.

isouravganguly · 2026-06-02T07:19:37Z

    - Mixpanel-swift (= 5.1.0)
-  - SCGateway (7.1.7)
+  - SCGateway-dhruv-migrate-to-sceneDelegate-007ae6e (7.1.6-24-debug)
  - scgateway_flutter_plugin (0.0.1):


[CRITICAL] These are debug branch builds (7.1.6-24-debug, 7.1.1-39-debug) pointing to cocoapodspec-internal. This lock file must be regenerated against the final release pod versions before merging to master.

WIll be updated on release

isouravganguly · 2026-06-02T07:19:37Z

+        }
+
+        fatalError("SwiftScLoanFlutterPlugin: No root view controller found. Ensure a UIWindow is set up in SceneDelegate or AppDelegate.")
+    }


[CRITICAL] fatalError will hard-crash the app if called during edge-case lifecycle moments — cold launch, background transitions, or multi-window on iPad. Change the return type to UIViewController? and let call sites handle nil gracefully instead of crashing unconditionally.

Flutter's method channel dispatch (handle(_:result:)) cannot fire before the FlutterViewController is installed as the root VC — the Flutter engine itself requires a valid window to initialize. By the time any Flutter call arrives, all three fallback chains (foreground scene → any scene → AppDelegate window) already have a rootViewController.

isouravganguly · 2026-06-02T07:19:37Z

+        }
+
+        fatalError("SwiftScgatewayFlutterPlugin: No root view controller found. Ensure a UIWindow is set up in SceneDelegate or AppDelegate.")
+    }


[CRITICAL] Same fatalError crash risk as in ScLoanFlutterPlugin. Return UIViewController? and handle nil at each call site.

Flutter's method channel dispatch (handle(_:result:)) cannot fire before the FlutterViewController is installed as the root VC — the Flutter engine itself requires a valid window to initialize. By the time any Flutter call arrives, all three fallback chains (foreground scene → any scene → AppDelegate window) already have a rootViewController.

isouravganguly · 2026-06-02T07:19:37Z

+            SmallcaseGatewaySdk.Result.IMR_SETUP -> {
+
+                val transRes = JSONObject(transactionResult.data!!)
+                transRes.put("success", true)


[CRITICAL] transactionResult.data!! throws NullPointerException if data is null. Use a safe null check and return a structured error to the Flutter layer.

It was not a threat as its already in try-catch block.So, no hard crash but still added result.error("TXN_ERROR", e.message ?: "Unknown error in transaction callback", null) logging for local insight

isouravganguly · 2026-06-02T07:19:37Z

    private var notificationObserver: NSObjectProtocol?

+    var currentViewController: UIViewController {
+        let foregroundScene = UIApplication.shared.connectedScenes


[MEDIUM] currentViewController is duplicated verbatim from ScLoanFlutterPlugin. Extract it into a shared internal utility (e.g. FlutterWindowResolver.swift) so any future fix applies to both plugins automatically.

Both ScLoan & ScGateway are published separately.

isouravganguly · 2026-06-02T07:19:37Z

+                                        resDict["signup"] = signup
+
+                                        let jsonData = try! JSONSerialization.data(withJSONObject: resDict, options: [])
+                                        let jsonString = String(data: jsonData, encoding: .utf8)


[MEDIUM] try! will crash if resDict contains a non-JSON-serialisable value. Move this inside the existing do/catch block and call result(FlutterError(...)) on failure.

shifted to try from try!

isouravganguly · 2026-06-02T07:19:37Z

+
+                                        return
+                                    }
+


[MEDIUM] If data is nil or cannot be cast to [String: Any], result() is never called and the Flutter method channel call hangs indefinitely. Add an explicit result(FlutterError(...)) in the else branch.

result(FlutterError(code: "IMR_SETUP_ERROR", message: error.localizedDescription, details: nil))

capturing for local insights now

isouravganguly · 2026-06-02T07:19:37Z

 @main
-@objc class AppDelegate: FlutterAppDelegate {
+@objc class AppDelegate: FlutterAppDelegate, FlutterImplicitEngineDelegate {
  override func application(


[MEDIUM] FlutterImplicitEngineDelegate and FlutterImplicitEngineBridge are not part of the public Flutter Engine API. This is fragile and may break silently on Flutter upgrades. Confirm this is a sanctioned integration path before merging.

SmartInvesting level issue: conforming to FlutterImplicitEngineDelegate is a hard requirement to which all SceneDelegate Migrated Apps should adhere to.

isouravganguly · 2026-06-02T07:19:37Z

 # Uncomment this line to define a global platform for your project
-platform :ios, '14.0'
+platform :ios, '15.0'



[MEDIUM] Bumping to iOS 15 drops support for iOS 14 users. The currentViewController logic already has #available(iOS 15.0, *) guards with iOS 13-compatible fallbacks, so the 15.0 floor is not strictly required. Revert to 14.0 unless there are other hard dependencies on iOS 15+.

SmartInvesting level issue

…rror paths

dporwal-shipit added 7 commits March 25, 2026 13:48

fix(ios): replace deprecated keyWindow with UIScene-safe connectedSce…

8b03d5e

…nes lookup

update thread handling

0648e6d

fix(ios): replace deprecated keyWindow with UIScene-safe connectedSce…

076c6f5

…nes lookup

Merge branch 'master' into dhruv/migrate-to-sceneDelegate

0c8be55

fix(ios): fix FlutterStreamHandler conformance

00434bc

fix(ios): annotate plugin class with @mainactor to resolve Swift con…

343e9a7

…currency errors

dporwal-shipit requested review from isouravganguly and rishabhjain92 June 1, 2026 13:19

isouravganguly reviewed Jun 2, 2026

View reviewed changes

chore: improve handling for nil data and null values in transaction e…

e86d3d0

…rror paths

dporwal-shipit requested a review from isouravganguly June 2, 2026 08:40

isouravganguly approved these changes Jun 2, 2026

View reviewed changes

dporwal-shipit merged commit b77e38d into master Jun 2, 2026

Uh oh!

Conversation

dporwal-shipit commented May 14, 2026

Uh oh!

isouravganguly left a comment • edited by dporwal-shipit Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

isouravganguly left a comment •

edited by dporwal-shipit

Loading