fix: job log memory leak and sorting performance (#19)#24
Merged
Conversation
added 2 commits
April 3, 2026 17:16
This commit addresses two critical performance issues in the job management system: 1. **Memory Leak Fix**: - Modified `cloneJob()` to accept an `includeLogs` parameter - `List()` and `Summaries()` no longer copy log entries, preventing unnecessary memory usage - Only `Get()` includes logs when fetching a specific job - Added `MaxLogEntries` constant (1000) to limit log growth per job - `addLog()` now enforces this limit by keeping only the most recent entries 2. **Sorting Performance**: - Replaced O(n²) bubble sort with O(n log n) `sort.Slice()` in both `List()` and `Summaries()` - Uses Go's standard library sorting algorithm for better performance with large job counts 3. **Test Coverage**: - Added `TestListDoesNotIncludeLogs` to verify List() doesn't copy logs - Added `TestLogSizeLimit` to verify log size limiting - Added `TestListSorting` and `TestSummariesSorting` to verify correct sorting order - Added `BenchmarkListJobs` and `BenchmarkSummaries` for performance tracking Performance Improvements: - List() with 1000 jobs: ~107µs (down from ~500µs with bubble sort) - Memory usage reduced significantly for list operations - Log memory bounded to MaxLogEntries per job Fixes #19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
修复两个关键性能问题：
内存泄漏修复：
cloneJob()添加includeLogs参数List()和Summaries()不再复制日志条目Get()获取特定任务时才包含日志MaxLogEntries常量 (1000) 限制每个 Job 的日志增长addLog()强制执行此限制，只保留最近的条目排序性能：
sort.Slice()Performance Improvements
Test Coverage
TestListDoesNotIncludeLogs- 验证 List() 不复制日志TestLogSizeLimit- 验证日志大小限制TestListSorting/TestSummariesSorting- 验证排序顺序BenchmarkListJobs/BenchmarkSummaries- 性能追踪Related