Skip to content

ci: harden example-project workflow and drop org secret - #31

Merged
shalousun merged 2 commits into
smart-doc-group:masterfrom
linwumingshi:fix/github-action
Sep 11, 2026
Merged

shalousun merged 2 commits into
smart-doc-group:masterfrom
linwumingshi:fix/github-action

Conversation

@linwumingshi

Copy link
Copy Markdown
Contributor

ci: harden example-project workflow and drop org secret

  • switch from pull_request_target to pull_request and remove
    ORG_CHECKOUT_TOKEN, since smart-doc-maven-plugin and
    smart-doc-example-cn are public repositories
  • add explicit contents: read permission and Maven dependency caching
  • rely on bash pipefail instead of grepping "[ERROR]" in build logs

- switch from pull_request_target to pull_request and remove
  ORG_CHECKOUT_TOKEN, since smart-doc-maven-plugin and
  smart-doc-example-cn are public repositories
- add explicit contents: read permission and Maven dependency caching
- rely on bash pipefail instead of grepping "[ERROR]" in build logs
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

@linwumingshi

🔍 Before proceeding, please review the contribution guidelines

This includes requirements for:

  • ✅ Commit message format (Angular Convention. feat, fix, etc.)
  • 🧹 Code style (execute mvn spring-javaformat:apply)
  • 📄 Documentation updates (if config changes)
  • 💡 Example code submission (for new features)

Thanks for your PR. 🙏
Please check again for your PR changes whether they contain any usage configuration change, such as Add new configuration or Change default value of configuration.
If so, please add or update documents (Markdown format) in the docs/ directory of the repository smart-doc-group/smart-doc-group.github.io.

In addition, if you have added new features, please provide example code in the repository smart-doc-group/smart-doc-example-cn. This will help other users understand how to use the new features.

Code Style Reminder:
The code should use the Spring code style. Please format your code using the command mvn spring-javaformat:apply. You can also install the Spring Java Format plugin for convenience.


🔍 提交前请务必完成以下检查

需特别注意:

  • ✅ 提交信息格式 (feat, fix 等类型)
  • 🧹 代码风格(执行 mvn spring-javaformat:apply
  • 📄 文档更新(配置变更需同步更新 docs)
  • 💡 示例代码(新功能需提供示例)

感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式或配置参数的变更,如:新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库smart-doc-group/smart-doc-group.github.io中的docs/目录下添加或更新文档(Markdown格式)。

另外,如果您添加了新功能,请在仓库smart-doc-group/smart-doc-example-cn中提供示例代码。这将帮助其他用户了解如何使用新功能。

代码风格提示:
请使用 Spring 代码风格。您可以通过命令 mvn spring-javaformat:apply 格式化代码。为了方便操作,您还可以安装 Spring Java Format 插件。

@shalousun
shalousun merged commit ff8e84d into smart-doc-group:master Sep 11, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants