Replace in-memory _relations with persisted reverse indexes#10
Merged
Conversation
Resolves #9. Relationship resolution (OneToMany, inverse OneToOne, ManyToMany) now uses persisted reverse indexes in stable storage instead of the fragile in-memory _relations dict. This makes relationship lookups O(k) instead of O(max_id), robust across canister upgrades and GC, and eliminates the need for Entity.instances() as a structural dependency. Breaking changes: - OneToMany cannot be set directly; use ManyToOne on each child - Entity.add_relation/get_relations/remove_relation removed - Entity.instances() deprecated (still works with warning) - RelationList removed; OneToMany/ManyToMany return plain lists - Serialization only includes owning-side FK references Co-authored-by: Cursor <cursoragent@cursor.com>
…rmatting reverse_index_delete now checks key existence before removal, preventing KeyError when deleting entities with empty ManyToMany relations. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_relationsdict with persisted reverse indexes in stable storage, making relationship resolution (OneToMany, inverse OneToOne, ManyToMany) O(k) instead of O(max_id)Entity.instances()for relationship access, which was causing IC instruction limit failures at scale (the demo simulator issue)Resolves #9
Breaking Changes
OneToManycannot be set directly; useManyToOneon each child insteadEntity.add_relation/get_relations/remove_relationremovedEntity.instances()deprecated (still works with aDeprecationWarning)RelationListremoved;OneToMany/ManyToManyreturn plain listsTest plan
TestReverseIndexResolutionspecifically validate the fixMade with Cursor