feat: migrate from dfx to icp CLI#3
Open
deucalioncodes wants to merge 2 commits into
Open
Conversation
- Dockerfile: install icp CLI via npm instead of dfx, use icp commands - test/entrypoint.sh: use icp network start/stop and icp deploy - test/dfx.json → test/icp.yaml: convert to icp CLI manifest format - test/Dockerfile_test: reference icp.yaml instead of dfx.json - README.md: update all commands and references to icp CLI - .gitignore: .dfx/ → .icp/ - Use install-icp-extension instead of install-dfx-extension
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| RUN DFX_VERSION=${DFX_VERSION} DFXVM_INIT_YES=true sh -ci "$(curl -fsSL https://internetcomputer.org/install.sh)" | ||
| ENV PATH="/root/.local/share/dfx/bin:$PATH" | ||
| # Install icp CLI and add to PATH | ||
| RUN npm install -g @icp-sdk/icp-cli |
There was a problem hiding this comment.
CLI version argument defined but never used
High Severity
ICP_CLI_VERSION=0.2 is declared as a build arg but never referenced in the npm install command. The install line npm install -g @icp-sdk/icp-cli always installs the latest version instead of the pinned version. The old code correctly passed DFX_VERSION to the install script. The install command needs to include the version, e.g. @icp-sdk/icp-cli@${ICP_CLI_VERSION}, to honor the pinned version.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate all dfx references to the new icp CLI.
Changes
icp network start/stopandicp deploy, useinstall-icp-extension.dfx/→.icp/Note
Medium Risk
Swaps the core local network/deploy tooling from
dfxtoicp, which can break container builds and CI if command/manifest semantics differ. Also bumpsic-basiliskand changes the bootstrap deployment flow, increasing the chance of environment/setup regressions.Overview
Migrates the dev container and test harness from
dfxto theicpCLI: the Docker image now installs@icp-sdk/icp-cli, usesicp network start/stop+icp deployfor the bootstrap deploy, and switches Basilisk toinstall-icp-extension(withic-basiliskbumped to0.11.2).Replaces
dfx.json-based configuration with anicp.yamlmanifest (including scripted Basilisk build steps) and updates the README, test Dockerfile, entrypoint script, and.gitignore(.dfx/→.icp/) accordingly.Written by Cursor Bugbot for commit 0db9392. This will update automatically on new commits. Configure here.