chore: bump ic-basilisk to 0.11.26, remove monkey-patch#197
Open
deucalioncodes wants to merge 1 commit into
Open
chore: bump ic-basilisk to 0.11.26, remove monkey-patch#197deucalioncodes wants to merge 1 commit into
deucalioncodes wants to merge 1 commit into
Conversation
v0.11.26 fixes _to_candid_text string escaping and makes candid_encode raise a catchable Python ValueError instead of trapping. The _ServiceCall monkey-patch in realm_installer is no longer needed. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ic-basiliskfrom 0.11.25 to 0.11.26 across all requirements files_ServiceCall.__init__monkey-patch fromrealm_installer/main.pyv0.11.26 fixes two bugs in the Basilisk template:
_to_candid_textnow properly escapes quotes and backslashes in string argumentsic.candid_encode()raises a catchable PythonValueErrorinstead of callingic_cdk::trap()With these fixes baked into the template, the monkey-patch workaround is no longer needed.
Test plan
Made with Cursor