Fix fan oscillate toggle handling and add EGLO fan codes#1556
Open
dankarization wants to merge 1 commit into
Open
Fix fan oscillate toggle handling and add EGLO fan codes#1556dankarization wants to merge 1 commit into
dankarization wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oscillateas a one-shot toggle command instead of replaying it on every later speed changeoscillatingattribute from Home Assistant state1230and1231Why
Issue #1112 describes fans where the oscillation command is a toggle that should only be sent once. The previous fan logic stored
oscillating=Trueand then resent the rawoscillatecommand on every subsequent speed change, which flipped oscillation back off on affected devices.Validation
python3 -m json.toolfor both new EGLO code filespython3 -m compileall custom_components/smartir/fan.pyturn_on -> oscillate(true) -> set_percentage -> set_percentagenow sendsspeed, oscillate, speed, speed