Skip to content

fix add allowed modules #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FelixFan1992 merged 1 commit into from
Apr 8, 2026
Merged

fix add allowed modules #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bindings/mcms_encoder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,10 @@ func (e *CCIPEntrypointArgEncoder) EncodeEntryPointArg(executingCallbackParams *
switch function {
case "accept_ownership":
return moduleStateObj.Encoder().McmsAcceptOwnershipWithArgs(stateObj, registryObj, executingCallbackParams)
case "add_allowed_modules":
return moduleStateObj.Encoder().McmsAddAllowedModulesWithArgs(registryObj, executingCallbackParams)
case "remove_allowed_modules":
return moduleStateObj.Encoder().McmsRemoveAllowedModulesWithArgs(registryObj, executingCallbackParams)
}

// OFFRAMP
Expand Down
43 changes: 43 additions & 0 deletions bindings/mcms_encoder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,6 +958,49 @@ func TestEncodeEntryPointArg_ManagedToken(t *testing.T) {
}
}

func TestEncodeEntryPointArg_StateObject(t *testing.T) {
encoder := &CCIPEntrypointArgEncoder{
registryObjID: "0x1234567890123456789012345678901234567890123456789012345678901234",
}

target := "0xabcdef1234567890abcdef1234567890abcdef1234567890abcdef1234567890"
stateObjID := "0x9999999999999999999999999999999999999999999999999999999999999999"
executingCallbackParams := &transaction.Argument{}

for _, tc := range []struct {
name string
function string
}{
{name: "add_allowed_modules", function: "add_allowed_modules"},
{name: "remove_allowed_modules", function: "remove_allowed_modules"},
} {
t.Run(tc.name, func(t *testing.T) {
data := []byte{}

result, err := encoder.EncodeEntryPointArg(
executingCallbackParams,
target,
"state_object",
tc.function,
stateObjID,
data,
[]string{},
)

require.NoError(t, err)
assert.NotNil(t, result)
assert.Equal(t, "state_object", result.Module.ModuleName)
assert.Equal(t, fmt.Sprintf("mcms_%s", tc.function), result.Function)
// 2 args: registry + executingCallbackParams (no stateObj / ccipRef)
require.Len(t, result.CallArgs, 2, "Expected 2 arguments: registry, executingCallbackParams")

registryFromResult, err := extractObjectID(result.CallArgs[0])
require.NoError(t, err)
assert.Equal(t, encoder.registryObjID, registryFromResult, "First arg should be the registry object")
})
}
}

func TestEncodeEntryPointArg_UnknownModule(t *testing.T) {
encoder := &CCIPEntrypointArgEncoder{
registryObjID: "0x1234567890123456789012345678901234567890123456789012345678901234",
Expand Down
35 changes: 18 additions & 17 deletions deployment/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ replace github.com/smartcontractkit/chainlink-sui => ../

require (
github.com/Masterminds/semver/v3 v3.4.0
github.com/block-vision/sui-go-sdk v1.1.3
github.com/block-vision/sui-go-sdk v1.1.4
github.com/ethereum/go-ethereum v1.17.1
github.com/google/go-cmp v0.7.0
github.com/smartcontractkit/chain-selectors v1.0.97
github.com/smartcontractkit/chainlink-ccip/deployment v0.0.0-20260311190822-5cbfc939dd16
github.com/smartcontractkit/chainlink-common v0.11.2-0.20260406055916-9aa6b6c0ae81
github.com/smartcontractkit/chainlink-deployments-framework v0.75.0
github.com/smartcontractkit/chainlink-sui v0.0.0-20251104205009-00bd79b81471
github.com/smartcontractkit/mcms v0.34.0
github.com/smartcontractkit/chainlink-sui v0.0.0-20260205175622-33e65031f9a9
github.com/smartcontractkit/mcms v0.40.1
github.com/stretchr/testify v1.11.1
golang.org/x/sync v0.19.0
)
Expand All @@ -28,7 +28,7 @@ require (
github.com/Microsoft/go-winio v0.6.2 // indirect
github.com/ProjectZKM/Ziren/crates/go-runtime/zkvm_runtime v0.0.0-20251001021608-1fe7b43fc4d6 // indirect
github.com/XSAM/otelsql v0.37.0 // indirect
github.com/aptos-labs/aptos-go-sdk v1.11.0 // indirect
github.com/aptos-labs/aptos-go-sdk v1.12.0 // indirect
github.com/avast/retry-go/v4 v4.6.1 // indirect
github.com/bahlo/generic-list-go v0.2.0 // indirect
github.com/benbjohnson/clock v1.3.5 // indirect
Expand Down Expand Up @@ -57,7 +57,7 @@ require (
github.com/fbsobreira/gotron-sdk v0.0.0-20250403083053-2943ce8c759b // indirect
github.com/fsnotify/fsnotify v1.9.0 // indirect
github.com/fxamacker/cbor/v2 v2.9.0 // indirect
github.com/gabriel-vasile/mimetype v1.4.10 // indirect
github.com/gabriel-vasile/mimetype v1.4.12 // indirect
github.com/gagliardetto/binary v0.8.0 // indirect
github.com/gagliardetto/solana-go v1.13.0 // indirect
github.com/gagliardetto/treeout v0.1.4 // indirect
Expand All @@ -67,8 +67,8 @@ require (
github.com/go-ole/go-ole v1.3.0 // indirect
github.com/go-playground/locales v0.14.1 // indirect
github.com/go-playground/universal-translator v0.18.1 // indirect
github.com/go-playground/validator/v10 v10.28.0 // indirect
github.com/go-viper/mapstructure/v2 v2.4.0 // indirect
github.com/go-playground/validator/v10 v10.30.1 // indirect
github.com/go-viper/mapstructure/v2 v2.5.0 // indirect
github.com/golang/protobuf v1.5.4 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/gorilla/websocket v1.5.3 // indirect
Expand All @@ -81,7 +81,7 @@ require (
github.com/hashicorp/go-hclog v1.6.3 // indirect
github.com/hashicorp/go-plugin v1.7.0 // indirect
github.com/hashicorp/yamux v0.1.2 // indirect
github.com/hasura/go-graphql-client v0.14.5 // indirect
github.com/hasura/go-graphql-client v0.15.1 // indirect
github.com/hdevalence/ed25519consensus v0.2.0 // indirect
github.com/holiman/uint256 v1.3.2 // indirect
github.com/invopop/jsonschema v0.13.0 // indirect
Expand Down Expand Up @@ -117,27 +117,27 @@ require (
github.com/pelletier/go-toml/v2 v2.2.4 // indirect
github.com/pkg/errors v0.9.1 // indirect
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
github.com/prometheus/client_golang v1.23.0 // indirect
github.com/prometheus/client_golang v1.23.2 // indirect
github.com/prometheus/client_model v0.6.2 // indirect
github.com/prometheus/common v0.65.0 // indirect
github.com/prometheus/common v0.66.1 // indirect
github.com/prometheus/procfs v0.16.1 // indirect
github.com/samber/lo v1.52.0 // indirect
github.com/santhosh-tekuri/jsonschema/v5 v5.3.1 // indirect
github.com/scylladb/go-reflectx v1.0.1 // indirect
github.com/shirou/gopsutil v3.21.11+incompatible // indirect
github.com/shopspring/decimal v1.4.0 // indirect
github.com/sigurn/crc16 v0.0.0-20211026045750-20ab5afb07e3 // indirect
github.com/smartcontractkit/chainlink-aptos v0.0.0-20251024142440-51f2ad2652a2 // indirect
github.com/smartcontractkit/chainlink-aptos v0.0.0-20260304220149-1006d5f7bd76 // indirect
github.com/smartcontractkit/chainlink-ccip/chains/solana v0.0.0-20260121163256-85accaf3d28d // indirect
github.com/smartcontractkit/chainlink-ccip/chains/solana/gobindings v0.0.0-20250912190424-fd2e35d7deb5 // indirect
github.com/smartcontractkit/chainlink-common/pkg/chipingress v0.0.10 // indirect
github.com/smartcontractkit/chainlink-protos/cre/go v0.0.0-20260326111235-8c09d1a4491f // indirect
github.com/smartcontractkit/chainlink-protos/job-distributor v0.17.0 // indirect
github.com/smartcontractkit/chainlink-protos/linking-service/go v0.0.0-20251002192024-d2ad9222409b // indirect
github.com/smartcontractkit/chainlink-protos/node-platform v0.0.0-20260205130626-db2a2aab956b // indirect
github.com/smartcontractkit/chainlink-ton v0.0.0-20260115170733-b16e9683d4d5 // indirect
github.com/smartcontractkit/chainlink-ton v0.0.0-20260219201907-054376f21418 // indirect
github.com/smartcontractkit/chainlink-tron/relayer v0.0.11-0.20250908203554-5bd9d2fe9513 // indirect
github.com/smartcontractkit/freeport v0.1.3-0.20250716200817-cb5dfd0e369e // indirect
github.com/smartcontractkit/freeport v0.1.3-0.20250828155247-add56fa28aad // indirect
github.com/smartcontractkit/grpc-proxy v0.0.0-20240830132753-a7e17fec5ab7 // indirect
github.com/smartcontractkit/libocr v0.0.0-20250912173940-f3ab0246e23d // indirect
github.com/spf13/cast v1.10.0 // indirect
Expand All @@ -151,7 +151,7 @@ require (
github.com/tklauser/go-sysconf v0.3.15 // indirect
github.com/tklauser/numcpus v0.10.0 // indirect
github.com/tyler-smith/go-bip39 v1.1.0 // indirect
github.com/valyala/fastjson v1.6.4 // indirect
github.com/valyala/fastjson v1.6.10 // indirect
github.com/wk8/go-ordered-map/v2 v2.1.8 // indirect
github.com/x448/float16 v0.8.4 // indirect
github.com/xssnick/tonutils-go v1.14.1 // indirect
Expand Down Expand Up @@ -182,14 +182,15 @@ require (
go.uber.org/multierr v1.11.0 // indirect
go.uber.org/ratelimit v0.3.1 // indirect
go.uber.org/zap v1.27.1 // indirect
go.yaml.in/yaml/v2 v2.4.2 // indirect
golang.org/x/crypto v0.48.0 // indirect
golang.org/x/exp v0.0.0-20260112195511-716be5621a96 // indirect
golang.org/x/net v0.49.0 // indirect
golang.org/x/exp v0.0.0-20260218203240-3dfff04db8fa // indirect
golang.org/x/net v0.50.0 // indirect
golang.org/x/sys v0.41.0 // indirect
golang.org/x/term v0.40.0 // indirect
golang.org/x/text v0.34.0 // indirect
golang.org/x/time v0.14.0 // indirect
golang.org/x/tools v0.41.0 // indirect
golang.org/x/tools v0.42.0 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20260114163908-3f89685c29c3 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20251222181119-0a764e51fe1b // indirect
google.golang.org/grpc v1.78.0 // indirect
Expand Down
Loading
Loading