Conversation
373897f to
4f3807b
Compare
* chore: running smoke * chore: trigger ci
314d5ac to
5d5e2d4
Compare
5d5e2d4 to
e8148bf
Compare
| require.True(t, exist, "feeQuoter view dest config not found") | ||
| require.True(t, destConfig.IsEnabled) | ||
| require.Equal(t, uint16(10), destConfig.MaxNumberOfTokensPerMsg) | ||
| require.Equal(t, uint16(1), destConfig.MaxNumberOfTokensPerMsg) |
There was a problem hiding this comment.
Max tokens should always be 1. This has been enforced somewhere else it appears, the value is more correct now
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Go module dependencies to use the updated Chainlink CCIP module layout (notably the chainlink-ccip/chains/evm module) and refreshes a broad set of related dependency versions, with accompanying test/doc/workflow adjustments.
Changes:
- Bump CCIP-related deps across modules (switching to
github.com/smartcontractkit/chainlink-ccip/chains/evmwhere applicable) plus assorted ecosystem upgrades (geth, otel, grpc, etc.). - Update integration tests and deployment adapter code to match the new CCIP package locations / helpers.
- Update tooling/docs (dependency graph
go.md, newGNUmakefile) and CI workflow targeting for smoke tests.
Reviewed changes
Copilot reviewed 11 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
staging-monitor/go.mod |
Updates CCIP/geth and other dependencies for the staging monitor module. |
scripts/.core_version |
Bumps the pinned Chainlink core ref used by workflows/scripts. |
integration-tests/go.mod |
Updates CCIP-related deps and other libraries for integration tests. |
integration-tests/go.sum |
Lockfile updates corresponding to integration test dependency bumps. |
integration-tests/deployment/ccip/cs_deployer_test.go |
Adjusts SetOCR3Config usage to new CCIP EVM deployment package. |
integration-tests/deployment/ccip/cs_add_lanes_test.go |
Updates an assertion to match new lane config expectations. |
go.md |
Updates the module dependency graph to reflect new CCIP module structure. |
devenv/go.mod |
Updates dependencies for the devenv module (including CCIP-related bumps). |
devenv/go.sum |
Lockfile updates corresponding to devenv dependency bumps. |
deployment/testadapter/test_adapter.go |
Switches TON adapter extra-args handling to the newer CCIP extraargs helper package. |
deployment/go.mod |
Updates deployment module deps to the new CCIP module layout and newer versions. |
GNUmakefile |
Adds make targets for multi-module go mod tidy and regenerating go.md. |
.github/workflows/test-smoke.yml |
Temporarily switches the target branch for triggering upstream CCIP smoke tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| WORKFLOW_FILE: .github/workflows/test_smoke.yml | ||
| TARGET_REPO: smartcontractkit/chainlink-ccip | ||
| TARGET_BRANCH: main | ||
| TARGET_BRANCH: chains-evm-go-mod # TODO: pin back to main once https://github.com/smartcontractkit/chainlink-ccip/pull/1972 is merged |
There was a problem hiding this comment.
TARGET_BRANCH is set to a moving branch name. For reproducible and stable CI runs, pin this to an immutable ref (tag or commit SHA), or at least gate this override behind a temporary flag and/or add a follow-up to revert once the upstream PR merges.
| TARGET_BRANCH: chains-evm-go-mod # TODO: pin back to main once https://github.com/smartcontractkit/chainlink-ccip/pull/1972 is merged | |
| # Default to the stable branch; allow a temporary override only when explicitly set. | |
| TARGET_BRANCH: ${{ vars.CCIP_SMOKE_TARGET_BRANCH_OVERRIDE != '' && vars.CCIP_SMOKE_TARGET_BRANCH_OVERRIDE || 'main' }} |
No description provided.