fix(test): increase simulated backend EVM timeout and use require for safe failure#21955
Open
fix(test): increase simulated backend EVM timeout and use require for safe failure#21955
Conversation
Fletch153
requested review from
AmrMohamedRezk,
KodeyThomas,
agusaldasoro,
makramkd,
matYang,
ogtownsend and
winder
Contributor
|
👋 Fletch153, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
✅ No conflicts with other open PRs targeting |
Fletch153
changed the title
Fletch153
force-pushed
the
fix/CORE-2383-assert-require-panic
branch
6 times, most recently
from
b92e5b9 to
422e6c1
Compare
…recation in ccipevm tests - Replace assert with require before slice access in executecodec_test to avoid panics on failure - Increase simulated backend EVM timeout from 5s to 60s in msghasher_test - Replace deprecated backends.NewSimulatedBackend with simulated.NewBackend in both test files
Fletch153
force-pushed
the
fix/CORE-2383-assert-require-panic
branch
from
422e6c1 to
d492f58
Compare
jmank88
reviewed
Apr 13, 2026
MStreet3
reviewed
Apr 13, 2026
MStreet3
approved these changes
Apr 13, 2026
Fletch153
force-pushed
the
fix/CORE-2383-assert-require-panic
branch
from
fa4ecbd to
ddd75cd
Compare
…port ordering Add the same RPCEVMTimeout: 60s override to executecodec_test.go that msghasher_test.go already has. Both tests call eth_call through the simulated backend and are subject to the default 5s timeout under -race -count=100. Also fixes time import ordering per review.
Fletch153
force-pushed
the
fix/CORE-2383-assert-require-panic
branch
from
ddd75cd to
85c7cf5
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RPCEVMTimeoutforeth_call-count=100 -race, race detector overhead (5-10x) causes EVM execution to exceed this timeoutRPCEVMTimeout: 60sso EVM calls complete reliably under loadassert.NoError→require.NoErrorbefore slice iteration so the test stops cleanly on any failure instead of panicking on an empty sliceRoot Cause
testSetup()usedbackends.NewSimulatedBackend()which inherits go-ethereum's default 5sRPCEVMTimeout. The test callscontract.DecodeExecuteReport()which goes througheth_call→doCall()→applyMessageWithEVM()— all subject to this timeout. Under race detector overhead, the 5s limit is exceeded intermittently.Test plan
execution aborted (timeout = 5s)panics under-count=100 -raceFixes: CORE-2383