fix(pgtest): use t.Fatalf instead of t.Errorf for missing CL_DATABASE_URL#21956
Open
fix(pgtest): use t.Fatalf instead of t.Errorf for missing CL_DATABASE_URL#21956
Conversation
…_URL pgtest.NewSqlxDB used t.Errorf (non-fatal) when CL_DATABASE_URL was missing, then returned nil. This caused SIGSEGV panics in downstream tests when they called methods on the nil *sqlx.DB. Changing to t.Fatalf stops test execution immediately, preventing the nil DB from propagating. Fixes: CORE-2371
Contributor
|
👋 Fletch153, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
|
|
Collaborator
Author
|
/rerun |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
t.Errorf→t.Fatalfinpgtest.NewSqlxDBwhenCL_DATABASE_URLis missing*sqlx.DBpropagating to downstream testsRoot Cause
t.Errorfis non-fatal, so the function returnednil. Any test callingpgtest.NewSqlxDBwithout a database URL would get a nil DB and panic on the first query.Test plan
pgtest.NewSqlxDBwithout DB fail cleanly instead of panickingFixes: CORE-2371