fix(test): use delta-based assertions for global Prometheus metrics in OCR3#21959
Open
fix(test): use delta-based assertions for global Prometheus metrics in OCR3#21959
Conversation
…n OCR3 Global Prometheus counters/histograms registered via promauto accumulate across test iterations when running with -count=N. Tests that assert exact absolute values fail on the 2nd+ iteration. Fix by capturing initial metric values before test operations and asserting on the delta instead. Fixes: CORE-2374
Contributor
|
👋 Fletch153, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
✅ No conflicts with other open PRs targeting |
|
|
Collaborator
Author
|
/rerun |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-count=N, these metrics accumulate across iterations, causing assertions to fail on iteration 2+Affected Tests
Test_ReportsGeneratedGauge— counter assertionsTest_DurationHistograms— histogram sample count assertionsTest_WrapperFactory— histogram sample count assertionsTest plan
-count=100 -racelocallyFixes: CORE-2374