fix(test): prevent Mercury v02 goroutine leak in timeout test#21962
Open
fix(test): prevent Mercury v02 goroutine leak in timeout test#21962
Conversation
TestV02_DoMercuryRequestV02_Timeout panicked with "Log in goroutine after Test has completed" because: 1. The client's Close() uses StopOnce which requires Start() — but the test never started the service, so Close() was a no-op 2. The mock used time.Sleep(15s) which ignored context cancellation, keeping goroutines alive after the test completed Fix by calling StartOnce in setupClient so Close() properly waits for goroutines, and replacing the mock's time.Sleep with a context-aware select that exits promptly on cancellation. Fixes: CORE-2372
Contributor
|
👋 Fletch153, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
✅ No conflicts with other open PRs targeting |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestV02_DoMercuryRequestV02_Timeoutpanicked with "Log in goroutine after Test has completed"setupClientnever calledStartOnce, soc.Close()(viaStopOnce) was a no-op — goroutines were never cleaned uptime.Sleep(15s)which ignored context cancellationStartOnceinsetupClientsoClose()properly waits for goroutines. Replacetime.Sleepwith context-awareselectand return typed nil response with errorTest plan
-count=20 -racelocally (202s, no panics)Fixes: CORE-2372