Skip to content

fix: prevent deadlock in donNotifier.Subscribe() on concurrent NotifyDonSet #21963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fletch153 wants to merge 3 commits into from
+6 −2
Closed

fix: prevent deadlock in donNotifier.Subscribe() on concurrent NotifyDonSet #21963

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e0aaea
fix: prevent deadlock in donNotifier.Subscribe() on concurrent Notify…
Fletch153 Apr 10, 2026
6c47383
fix: prevent deadlock in donNotifier.Subscribe() on concurrent Notify…
Fletch153 Apr 10, 2026
570df83
fix: use non-blocking send for cached DON value in Subscribe()
Fletch153 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions core/capabilities/don_notifier.go
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@jmank88 jmank88 Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not as described. Does it actually fix the issue?

Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,12 @@ func (n *donNotifier) Subscribe(ctx context.Context) (<-chan capabilities.DON, f

n.subscribers.Store(s, struct{}{})

if n.don.Load() != nil {
s <- *n.don.Load()
if d := n.don.Load(); d != nil {
select {
case s <- *d:
default:
// Channel already has a value from a concurrent NotifyDonSet.
}
}

return s, unsubscribe, nil
Expand Down
Loading