fix(test): use unique bridge names and relaxed count assertions#21966
Open
fix(test): use unique bridge names and relaxed count assertions#21966
Conversation
TestORM_UpdateBridgeType used a hardcoded "UniqueName" and asserted the global bridge count was exactly 1. With shared DB state from parallel tests or -count=N, the global count includes other bridges. Use UUID-based names and assert >= 1 instead of exact count. Verify deletion by checking the specific bridge is not found. Fixes: CORE-2391
Contributor
|
✅ No conflicts with other open PRs targeting |
The GreaterOrEqual count check was still fragile. The test only needs to verify its own bridge exists and can be deleted — not count how many bridges exist globally. Fixes: CORE-2391
The txdb wrapper should provide per-test transaction isolation, so exact count assertions are valid. Restore them — if CI fails, the real bug is broken DB isolation, not the test. The only change from the original test is UUID-based bridge names to avoid hardcoded "UniqueName" collisions. Fixes: CORE-2391
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestORM_UpdateBridgeTypeused hardcoded name "UniqueName" and asserted globalbridge_typescount was exactly 1-count=N), the global count includes bridges from other tests>=1instead of exact count; verify deletion viaFindBridgeerrorTest plan
Fixes: CORE-2391