fix(test): prevent goroutine leak in PausableTicker and CronTicker tests#21968
Open
fix(test): prevent goroutine leak in PausableTicker and CronTicker tests#21968
Conversation
PausableTicker.Destroy() stops the ticker but doesn't close the channel. Goroutines running for-range on Ticks() block forever, accumulating across -count=N iterations. Add done channels so goroutines exit when the test completes. Also reduce CronTicker verification sleep from 1s to 200ms. Fixes: CORE-2401
Contributor
|
👋 Fletch153, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
✅ No conflicts with other open PRs targeting |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestPausableTickerandTestCronTickerleak goroutines across-count=NiterationsDestroy()stops the ticker but doesn't closeTicks()channel — goroutines infor rangeblock foreverdonechannels so goroutines exit when the test completesTest plan
-count=50 -racelocally (155s)Fixes: CORE-2401