Skip to content

Side-by-side comparison #21976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kalverra wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Side-by-side comparison #21976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af206b4
Side-by-side comparison
kalverra Apr 10, 2026
876768a
bust cache again
kalverra Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/setup-go/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ runs:
# If multiple jobs call actions/cache, then only one will get priority to create upon a cache miss.
# We will only restore the cache by default (by calling actions/cache/restore) and let the
# `go-mod-cache.yml` workflow handle the creation.
- uses: actions/cache/restore@v4
- uses: actions/cache/restore@v5
if: ${{ inputs.restore-module-cache-only == 'true' }}
name: Cache Go Modules (Restore)
id: cache-modules-restore
Expand All @@ -86,7 +86,7 @@ runs:

# If this is called, then it will create the cache entry upon a cache miss.
# The cache is created after a cache miss, and after job completes successfully.
- uses: actions/cache@v4
- uses: actions/cache@v5
if: ${{ inputs.restore-module-cache-only != 'true' }}
id: cache-modules
name: Cache Go Modules
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/ci-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,14 @@
contents: read
actions: read
steps:
# DEBUG: Checking resources
- name: Monitor
uses: kalverra/octometrics-action@main

Check failure on line 252 in .github/workflows/ci-core.yml

View workflow job for this annotation

GitHub Actions / Validate Workflow Changes 

  1. main is not a valid SHA reference (sha-ref / error)
  2. No version comment found (version-comment / warning)
with:
job_name: Core Tests (${{ matrix.type.cmd }}) # Required input to match API job data with runner job data
skip_comment: "true" # Optional input that can skip posting comments to a PR, default false
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Optional, but highly recommended to prevent rate limiting
- name: Enable S3 Cache for Self-Hosted Runners
uses: runs-on/action@742bf56072eb4845a0f94b3394673e4903c90ff0 # v2.1.0
with:
Expand Down Expand Up @@ -336,7 +344,7 @@
RUN_QUARANTINED_TESTS: "true" # always run quarantined tests in CI
JUNIT_FILE: ${{ github.workspace }}/junit.xml
run: |
GODEBUG=goindex=0 ./tools/bin/${{ matrix.type.cmd }} ./...
GODEBUG=goindex=0,testcache=1 ./tools/bin/${{ matrix.type.cmd }} ./... # DEBUG: drop ,testcache=0 to re-enable test cache
# See: https://github.com/golang/go/issues/69179

- name: Analyze and upload test results
Expand Down
Loading