Test/db fixes 10 04 26

[erikburt]

Notes

• When authenticating an empty/non-existing keystore, a new one is initialized with the configured password

• A CSA key is also generated alongside the keystore in the first sub-test in TestShell_BeforeNode and is leaked to all subsequent tests

  • The first test actually creates the CSA key and technically sets the password/encryption key for the keyring
  • Because incorrect_password subtest is run after correct_password which generates a keyring with a different password, the tests succeed. If run in a different order, they would fail.

• Swiching TestShell_BeforeNode to use a custom newAppWithOpts method allows you to properly configuration parameters, allowing for a txdb connection.

  • However, with the txdb connection there's no key leakage, which causes incorrect_password subtest to fail BECAUSE, the keytore is empty. So when trying to unlock it, it actually just creates a new one.

[github-actions]

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

[github-actions]

✅ No conflicts with other open PRs targeting develop

[trunk-io]

     

Failed Test	Failure Summary	Logs
TestShell_IndexStarkNetNodes	The test 'TestShell_IndexStarkNetNodes' failed without providing specific error details.	Logs ↗︎
TestShell_IndexEVMNodes	The test 'TestShell_IndexEVMNodes' failed without providing specific error details.	Logs ↗︎
TestShell_IndexEVMNodes	The test 'TestShell_IndexEVMNodes' failed without providing specific error details.	Logs ↗︎
TestShell_IndexBridges	The test named 'TestShell_IndexBridges' failed during execution.	Logs ↗︎

... and 140 more

View Full Report ↗︎ ⋅ Docs

[cl-sonarqube-production]

Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)
18.89% Technical Debt Ratio on New Code (required ≤ 4%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE