Fix query rewrite rules to match by source table#30
Merged
Conversation
Rules are defined against database tables (e.g. semantic_events) but were being matched against Cube.js cube names. This broke filtering when cubes had different names than their source tables. Now parses active dataschemas to build a cube→table mapping, applies rules to all cubes backed by the target table, and skips cubes that lack the rule's dimension. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
doktorhelgi
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
semantic_events) but were matching against Cube.js cube names, which can differpartition)Test plan
MyEventsbacked bysemantic_events)MyEventspartitiondimension are skipped gracefully🤖 Generated with Claude Code