Skip to content

Filesystem-based persistent work list #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jfcloutier wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Filesystem-based persistent work list #75

jfcloutier wants to merge 5 commits into from

Conversation

@jfcloutier
Copy link
Collaborator

@jfcloutier jfcloutier commented Jan 25, 2022 •
edited
Loading

No description provided.

@jfcloutier jfcloutier marked this pull request as draft January 25, 2022 21:36
@jfcloutier
Copy link
Collaborator Author

jfcloutier commented Jan 26, 2022

I'm not sure about this, but is it Enum.reverse here instead of Enum.sort?

No but the code can be simplified to
if Enum.empty?(state.pending), do: nil, else: Enum.min(Map.values(state.pending))

@jfcloutier jfcloutier force-pushed the persistent branch 5 times, most recently from 8a9084b to f285ce8 Compare January 26, 2022 22:08
@jfcloutier jfcloutier marked this pull request as ready for review January 27, 2022 00:25
grace-in-wonderland
grace-in-wonderland approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@grace-in-wonderland grace-in-wonderland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhunleth fhunleth Awaiting requested review from fhunleth

1 more reviewer

@grace-in-wonderland grace-in-wonderland grace-in-wonderland approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jfcloutier @grace-in-wonderland