Completed the elevator assignment #12
Open
NachtMk wants to merge 13 commits intosmatechnologies-engineering:masterfrom
Open
Completed the elevator assignment #12NachtMk wants to merge 13 commits intosmatechnologies-engineering:masterfrom
NachtMk wants to merge 13 commits intosmatechnologies-engineering:masterfrom
Conversation
further refactorization and testing.
to elevator.log.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The program has a maintainability score over 70 via a Plato check. Run the build.sh with Linux shell or similar and it should run the npm test, plate report, and npm start. The output file is called elevator.log.json. For the convenient of testing, I made the elevator waiting and stopping time of the elevator to be 100ms and 300ms instead. It can easily be changed in the elevator.request.js