Fix bare links in docs against Rust 1.53#563
Closed
jdisanti wants to merge 1 commit intosmithy-lang:mainfrom
jdisanti:fix-doc-links
Closed
Fix bare links in docs against Rust 1.53#563jdisanti wants to merge 1 commit intosmithy-lang:mainfrom jdisanti:fix-doc-links
jdisanti wants to merge 1 commit intosmithy-lang:mainfrom
jdisanti:fix-doc-links
Conversation
Collaborator
|
would be nice to have a generated code diff to audit |
Contributor
Author
|
On second thought, there isn't really a good way to fix this without full parsing of the documentation. There are cases in the documentation such as this that should not get transformed: Or I'll table this and start on the long-term approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust 1.53 added a lint for bare URLs: rust-lang/rust#81764
This PR fixes doc generation so that docs continue to build with the latest stable compiler, but does not attempt to be the long-term documentation normalization strategy.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.